Re: [GENERAL] currval and DISCARD ALL

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Marko Kreen <markokr(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Adrian Klaver <adrian(dot)klaver(at)gmail(dot)com>, Nigel Heron <nigel(at)psycode(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [GENERAL] currval and DISCARD ALL
Date: 2013-04-19 14:05:36
Message-ID: CAFcNs+pXd3am8Uq086TNLLWiiLt=wRhBjnthqt9988Qyg69H2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

On Fri, Apr 19, 2013 at 10:50 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

>
> [...]
>
> So it seems to me that we pretty much already made a decision that the
> controlling definition of DISCARD ALL is that, as the fine manual says
> "DISCARD ALL resets a session to its original state". Whatever
> decision we make now ought to be consistent with that.
>
> IOW, I don't care whether we introduce a new subcommand or not. But I
> *do* think that that we ought to make our best effort to have DISCARD
> ALL clear everything that smells like session-local state. Random
> incompatibilities between what you see when running under a connection
> pooler and what you see when connecting the DB directly are *bad*,
> regardless of whether a well-designed application should be relying on
> those particular things or not. The whole point of having a
> transparent connection pooler is that it's supposed to be transparent
> to the application.
>
>
+1

The attached wip patch do that and introduce a subcommand 'SEQUENCES', but
if we decide to don't add a new subcommand to DISCARD, then its easier to
modify the patch.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Blog sobre TI: http://fabriziomello.blogspot.com
>> Perfil Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello

Attachment Content-Type Size
discard_sequences.patch application/octet-stream 3.9 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Robert Haas 2013-04-19 14:12:02 Re: [GENERAL] currval and DISCARD ALL
Previous Message Robert Haas 2013-04-19 13:50:19 Re: [GENERAL] currval and DISCARD ALL

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2013-04-19 14:11:20 Re: elog() error, trying CURENT OF with foreign table
Previous Message Robert Haas 2013-04-19 13:50:19 Re: [GENERAL] currval and DISCARD ALL