| From: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
|---|---|
| To: | Alexandra Wang <alexandra(dot)wang(dot)oss(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Nikita Glukhov <glukhov(dot)n(dot)a(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, "David E(dot) Wheeler" <david(at)justatheory(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com> |
| Subject: | Re: SQL:2023 JSON simplified accessor support |
| Date: | 2025-03-03 19:16:09 |
| Message-ID: | CAFY6G8cY5SUG5L-0ryVpom6HynE49p8-XQ59qkaEgnZZJ-c4Rg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Alex,
The code comments and the commit messages help a lot when reviewing! Thanks for
the new version.
The code LGTM and check-world is happy. I've also performed some tests and
everything looks good!
Just some minor points about this new version:
## v9-0005
Typo on commit message title
## v9-0006
> + * The following functions create various types of JsonPathParseItem nodes,
> + * which are used to build JsonPath expressions for jsonb simplified accessor.
>
Just to avoid misinterpretation I think that we can replace "The following
functions" with "The make_jsonpath_item_* functions" since we can have more
functions in the future that are not fully related with these. Does that make
sense?
--
Matheus Alcantara
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Hunter | 2025-03-03 19:19:59 | Re: int64 support in List API |
| Previous Message | Nathan Bossart | 2025-03-03 19:11:15 | Re: Improve CRC32C performance on SSE4.2 |