Re: Add a filed to PageHeaderData

On Tue, Jun 24, 2014 at 3:27 PM, Andres Freund <andres(at)2ndquadrant(dot)com>
wrote:

> On 2014-06-24 15:23:54 +0430, Soroosh Sardari wrote:
> > On Tue, Jun 24, 2014 at 2:40 PM, Kevin Grittner <kgrittn(at)ymail(dot)com>
> wrote:
> >
> > > Soroosh Sardari <soroosh(dot)sardari(at)gmail(dot)com> wrote:
> > >
> > > > I check this problem with a virgin source code of
> > > > postgresql-9.3.2. So the bug is not for my codes.
> > >
> > > > By the way, following code has two different output and it is
> > > > weird.
> > >
> > > I can confirm that I see the difference in 9.3.2, and that I don't
> > > see the difference in 9.3.4. Upgrade.
> > >
> > > http://www.postgresql.org/support/versioning/
> > >
> > > There's really no point in reporting a possible bug on a version
> > > with known bugs which have already had fixes published.
> > >
> > > --
> > > Kevin Grittner
> > > EDB: http://www.enterprisedb.com
> > > The Enterprise PostgreSQL Company
> > >
> >
> >
> > wow, it's arch-dependent.
> > in the 32-bit compiled of PG9.3.2 the code has same output and in 64-bit
> > binary of same code output is different!!
> >
> > The problem is not about the sql code I posted in the last email. Problem
> > could be different in any architecture,
> > In 32-bit or 64-bit architecture adding a char array of length 20 to
> > PageHeaderData cause error in regression test.
>
> You likely didn't adapt SizeOfPageHederData.
>
> Greetings,
>
> Andres Freund
>
> --
> Andres Freund http://www.2ndQuadrant.com/
> PostgreSQL Development, 24x7 Support, Training & Services
>

#define SizeOfPageHeaderData (offsetof(PageHeaderData, pd_linp))

I think ,the macro does not need any change!