| From: | Yosry Muhammad <yosrym93(at)gmail(dot)com> |
|---|---|
| To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
| Cc: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org> |
| Subject: | Re: [GSoC] Query History Upgrade |
| Date: | 2019-08-14 10:22:49 |
| Message-ID: | CAFSMqn9woe4gneULz1biT7e8izgYGd8_z2o09o57ywybLvpL9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
On Wed, Aug 14, 2019 at 12:03 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Yosry
>
> I have found following issues:
>
> - Jasmine test cases are failing.
> - Browser error when applying the patch and open the query tool.
> Previously saved queries are there:
> - [image: Screenshot 2019-08-14 at 3.21.21 PM.png]
>
> These problems did not occur when I checked the patch. I should have
re-checked everything after merging with master, my bad. Sorry about that.
Working on it.
>
> -
> - Toggle Switch should have text "Yes/No" as we already have label
> "Show queries generated internally by pgAdmin?"
> - Show/Hide query works on click of label as well.
>
> I am sorry I don't understand. Do you want me to make it toggle if the
label is clicked as well?
>
> - For View/Edit Data it seems to take all the queries as internal, is
> this expected ?
>
> Yes, as all queries in View/Edit Data are generated internally by pgAdmin.
I am working on providing an updated patch ASAP.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-08-14 10:33:03 | Re: [GSoC] Query History Upgrade |
| Previous Message | Akshay Joshi | 2019-08-14 10:06:13 | Re: [GSoC] Query History Upgrade |