Re: [GSoC] Query History Upgrade

Please find an updated patch with the mentioned issue fixed. I am sorry you
spent so much time reviewing this and finding bugs.

On Wed, Aug 14, 2019 at 2:34 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Yosry
>
> I am still facing following issues:
>
> - No icons for already saved(before applying your patch) query in
> query history. Is this expected?
> - Internal queries are visible even if toggle switch is set to "No".
> Following are the steps to reproduce:
> - Create a table with primary key.
> - Open query tool and run "SELECT * FROM <table_name>".
> - Clear all old query history from query tool.
> - Make sure toggle switch for show internal query is set to "*Yes*".
> - Insert first record, query history will show "BEGIN" ,"INSERT"
> and COMMIT queries.
> - Set toggle switch to "*No*" and insert second record. Second
> record should not be visible as switch set to "*No*".
> - Now try switching toggle, when it is set to "Yes" it will show
> queries for first record and when it is set to "No" it will show queries
> for second record.
>
>
> On Wed, Aug 14, 2019 at 4:47 PM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:
>
>> Please find an updated patch attached with the aforementioned issues
>> fixed.
>>
>> On Wed, Aug 14, 2019 at 12:33 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Wed, Aug 14, 2019 at 3:53 PM Yosry Muhammad <yosrym93(at)gmail(dot)com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> On Wed, Aug 14, 2019 at 12:03 PM Akshay Joshi <
>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Yosry
>>>>>
>>>>> I have found following issues:
>>>>>
>>>>> - Jasmine test cases are failing.
>>>>> - Browser error when applying the patch and open the query tool.
>>>>> Previously saved queries are there:
>>>>> - [image: Screenshot 2019-08-14 at 3.21.21 PM.png]
>>>>>
>>>>> These problems did not occur when I checked the patch. I should have
>>>> re-checked everything after merging with master, my bad. Sorry about that.
>>>> Working on it.
>>>>
>>>>>
>>>>> -
>>>>> - Toggle Switch should have text "Yes/No" as we already have label
>>>>> "Show queries generated internally by pgAdmin?"
>>>>> - Show/Hide query works on click of label as well.
>>>>>
>>>>> I am sorry I don't understand. Do you want me to make it toggle if the
>>>> label is clicked as well?
>>>>
>>>
>>> Currently it is happening. Queries should not be show/hide when
>>> click on label.
>>>
>>>>
>>>>> - For View/Edit Data it seems to take all the queries as internal,
>>>>> is this expected ?
>>>>>
>>>>> Yes, as all queries in View/Edit Data are generated internally by
>>>> pgAdmin.
>>>>
>>>> I am working on providing an updated patch ASAP.
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Yosry Muhammad Yosry*
>>
>> Computer Engineering student,
>> The Faculty of Engineering,
>> Cairo University (2021).
>> Class representative of CMP 2021.
>> https://www.linkedin.com/in/yosrym93/
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
*Yosry Muhammad Yosry*

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.
https://www.linkedin.com/in/yosrym93/