From: | Yosry Muhammad <yosrym93(at)gmail(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org> |
Subject: | Re: [GSoC] Query History Upgrade |
Date: | 2019-08-16 11:58:08 |
Message-ID: | CAFSMqn-sJZRBLMAzpCk2C=gsF1RveAVMW3wwVphbFMqg22nUxg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks all for the thorough review.
On Fri, Aug 16, 2019, 1:48 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Thanks patch applied.
>
> On Wed, Aug 14, 2019 at 7:24 PM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:
>
>> Hi,
>>
>> On Wed, Aug 14, 2019 at 3:50 PM Yosry Muhammad <yosrym93(at)gmail(dot)com>
>> wrote:
>>
>>> Please find an updated patch with the mentioned issue fixed. I am sorry
>>> you spent so much time reviewing this and finding bugs.
>>>
>>> On Wed, Aug 14, 2019 at 2:34 PM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Yosry
>>>>
>>>> I am still facing following issues:
>>>>
>>>> - No icons for already saved(before applying your patch) query in
>>>> query history. Is this expected?
>>>>
>>>> I am sorry I missed this, yes this is expected as there is no way to
>> identify internally generated queries before the patch.
>> Thanks.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2019-08-16 12:06:43 | pgAdmin 4 commit: Add Reverse Engineered SQL tests for Columns. Fixes # |
Previous Message | Akshay Joshi | 2019-08-16 11:47:54 | Re: [GSoC] Query History Upgrade |