[GSoC] Support editing resultsets from tables with OIDs

From: Yosry Muhammad <yosrym93(at)gmail(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Dave Page <dpage(at)pgadmin(dot)org>
Subject: [GSoC] Support editing resultsets from tables with OIDs
Date: 2019-07-25 12:01:28
Message-ID: CAFSMqn-YcFFUdSApFn6-=CeGFtARRJNkZv+tGJ7ORMe7ahftEQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,
Please find a patch attached to add supporting of resultsets from tables
with OIDs as updatable resultsets (with updated test cases and docs) - this
is a part of a GSoC project. Please review !
This patch also includes a small refactor of the previous patch and a small
bug fix that occurred when the query resultset had no rows but was
updatable (row additions were not permitted, although they should be).

On a different note, one of the feature tests fails (on master), probably
due to a small typo. In query_tool_tests.py this function call:

self.page.find_by_xpath(
'//div[contains(@class, "sql-editor-message") and '
'contains(string(), "CREATE TABLE")]'
)

on lines 371-374 produces an exception that the element cannot be found,
this is probably due to the fact that the message returned by the query
executed before this call does not contain the string "CREATE TABLE". Just
letting you know about this.

Thanks and regards!
--

*Yosry Muhammad Yosry*

Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.
https://www.linkedin.com/in/yosrym93/

Attachment Content-Type Size
editing_resultsets_with_oids.patch text/x-patch 15.3 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-07-25 12:25:57 pgAdmin 4 commit: Fix accessibility issue for Datetime cell in backgrid
Previous Message Fahar Abbas 2019-07-25 11:59:28 Re: pgAdmin4 v4.11 candidate builds