From: | Matthew Kleiman <mkleiman(at)pivotal(dot)io> |
---|---|
To: | Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, George Gelashvili <ggelashvili(at)pivotal(dot)io> |
Subject: | Re: [pgAdmin4][Patch][RM2257]: Query tool - Insert row doesn't use default values |
Date: | 2017-04-04 16:37:34 |
Message-ID: | CAFS4TJbr9cCQUgOVXHuLBFtsxqo7ka3-0DpyAZ6DKPOTm2ysgg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Surinder,
We looked at your fix for default values in the query tool editor.
We think the user experience could be further improved by seeing the actual
default value instead of the empty cell.
As an intermediate step, there would be user value in seeing "[default]"
instead of the blank cell (or what used to be "[null]").
Thanks,
George and Matt
On Sat, Apr 1, 2017 at 7:45 AM, Surinder Kumar <
surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
> Hi
>
> Issues fixed:
>
> 1. If a column is defined with a default modifier, there is now way to
> insert the row with those defaults.
> The column will be left blank and it will take default value automatically.
>
> 2. If a column has a not-null constraint then an error is returned and
> the row is not inserted.
> The column will be left blank
>
>
> The default values for new added rows will be displayed on
> refresh/execute.
>
> Please find attached patch and review.
>
>
> Thanks
> Surinder
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Atira Odhner | 2017-04-04 18:16:13 | Re: [patch] Column selection on SQLEditor |
Previous Message | Atira Odhner | 2017-04-04 15:31:38 | Re: [patch] Column selection on SQLEditor |