Re: [patch] Column selection on SQLEditor

Hi Dave,

I've updated the attached patch to include a change to the "Paste Rows"
button. It will now be enabled *only* if there are rows on the clipboard.

Good luck with the release on Monday morning!

Matt

On Fri, Apr 7, 2017 at 4:12 PM, Matthew Kleiman <mkleiman(at)pivotal(dot)io> wrote:

> Hi Dave
>
> The attached patch now includes a fix for the regression you found. When
> the query tool is in edit mode, the user can copy rows and paste them.
> I've also removed the two lines from copy_data.js that you mentioned so
> that users can copy from the table even after they have copied once.
>
> I have noticed that the "Paste Rows" button remains enabled even if only
> columns are copied. Although pressing this button won't do anything unless
> rows have been copied to the clipboard, this might prove confusing to
> users. I am going to look at disabling this button until rows are in the
> clipboard. I will let you know if I have anything for you by the end of
> today.
>
> Best,
> Matt
>
> On Fri, Apr 7, 2017 at 10:27 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> On Fri, Apr 7, 2017 at 2:49 PM, Atira Odhner <aodhner(at)pivotal(dot)io> wrote:
>> >> The one tweak I made to the patch was to remove the code that disabled
>> >> the Copy button from the top of copy_data.js. I think the button
>> >> should remain enabled to allow the user to copy again, in case they
>> >> use the clipboard for something else and then need to refresh it with
>> >> the data. Of course, it should still be disabled when there is nothing
>> >> selected that can be copied.
>> >
>> > Yes, the copy button enablement behavior was a bit strange. I'm glad
>> you
>> > found a fix for it. Do you mind sending us your updated patch?
>>
>> I literally just removed lines 5 & 6 of copy_data.js.
>>
>> >> Any chance this can be fixed before Monday? I would like to include it
>> >> in the release if possible
>> >
>> > I'll drop a bug at the top of our backlog, and Matt will take a look at
>> it
>> > today. We'll let you know at the end of the day where we're at with this
>> > fix.
>>
>> Thanks - and sorry to hear your moving onto other things :-(
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>