From: | Matthew Kleiman <mkleiman(at)pivotal(dot)io> |
---|---|
To: | George Gelashvili <ggelashvili(at)pivotal(dot)io> |
Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>, Robert Eckhardt <reckhardt(at)pivotal(dot)io>, Shruti Iyer <siyer(at)pivotal(dot)io>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Joao Pedro De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
Subject: | Re: [pgAdmin4][Patch]: Refactor of the History Tab |
Date: | 2017-07-05 13:54:07 |
Message-ID: | CAFS4TJZOiP5eEvRacKGmsn0XG2AL9084THNMkf=budtfRcu6qg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
>
> 1) I see the font used for class .query-history .entry is monospace,
> shouldn't it be Helvetica as per style guide ? the font for Messages > text
> is also monospace.
>
As per Dave's comment, we have added this to the styleguide backlog. We
will be adding monospace entries to the styleguide.
2) Can 1px top border be added above first entry in left panel to
> differentiate from above panels ?
We have updated the patch to include a 1px solid #cccccc border at the top.
3) No query execution message appears if i run same query second time,
> please refer screenshot.
Appears to be fixed with Murtuza's patch.
Thanks,
Sarah and Matt
On Mon, Jul 3, 2017 at 10:05 AM, George Gelashvili <ggelashvili(at)pivotal(dot)io>
wrote:
> Hi
>
>> 2) Can 1px top border be added above first entry in left panel to
>> differentiate from above panels ?
>>
>> It sounds like you're describing the distinction between the query
> history entries and the Messages, History, etc. tab bar (screenshot
> attached).
> If so, the gray/blue contrast should be sufficient to differentiate.
>
> Thanks,
> Shirley and George
>
Attachment | Content-Type | Size |
---|---|---|
refactor-react-history.diff | text/plain | 19.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | pgAdmin 4 Jenkins | 2017-07-05 13:59:02 | Build failed in Jenkins: pgadmin4-master-python35 #218 |
Previous Message | Dave Page | 2017-07-05 13:20:40 | Re: [pgAdmin4][Patch]: Allow user to delete Tab via Shift-Tab in query editor |