| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Date: | 2025-03-06 03:47:52 |
| Message-ID: | CAFPTHDbjb0Sv_soDgESw7qMu+af7_SBY6ob1EVWUkFWAXWdrpw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 28, 2025 at 11:34 PM Shubham Khanna
<khannashubham1197(at)gmail(dot)com> wrote:
>
>
> The attached Patch contains the suggested changes.
>
> Thanks and regards,
> Shubham Khanna.
Some comments:
1.
+ <varlistentry>
+ <term><option>-a</option></term>
+ <term><option>--all</option></term>
+ <listitem>
+ <para>
+ For all source server non-template databases create subscriptions for
+ create subscriptions for databases with the same names on the
+ target server.
+ Subscription names, publication names, and replication slot names are
+ automatically generated. Cannot be used together with
+ <option>--database</option>, <option>--publication</option>,
+ <option>--replication-slot</option> or <option>--subscription</option>.
Don't start the sentence with "Cannot". Change the sentence to "This
option cannot be used together with ..."
similar sentences used in 3 other places below this as well. Change all of them.
2.
+# Verify that only user databases got subscriptions (not template databases)
change to "Verify that only user databases have subscriptions"
regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2025-03-06 03:56:33 | Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility. |
| Previous Message | Andres Freund | 2025-03-06 03:41:24 | Re: Statistics Import and Export |