| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Hubert Lubaczewski <depesz(at)depesz(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Excessive number of replication slots for 12->14 logical replication |
| Date: | 2022-08-11 15:04:30 |
| Message-ID: | CAFPTHDbVNXXwug7PX=VjMvWqv9eZzDmbgSEq=6BpLdBBv4XJ5Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Aug 4, 2022 at 5:42 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Thank you for working on this. I have a comment and a question:
>
> * This has to be done after updating the state
> because otherwise if
> * there is an error while doing the database
> operations we won't be
> - * able to rollback dropped slot.
> + * able to rollback dropped slot or origin tracking.
>
> I think we can actually roll back dropping the replication origin. So
> the above comment is true for only replication slots.
>
Fixed this.
regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-fix-excessive-replication-origin-slots-issue.patch | application/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2022-08-11 15:51:40 | BUG #17582: Error: Package: gdal-libs-1.11.4-12.rhel7.x86_64 (@pgdg11) |
| Previous Message | Tom Lane | 2022-08-11 14:23:15 | Re: BUG #17579: 15beta2: strange error when trying to use MERGE statement as a CTE |