Re: Track statistics for streaming of in-progress transactions

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Subject: Re: Track statistics for streaming of in-progress transactions
Date: 2020-10-22 06:02:06
Message-ID: CAFPTHDbG-porF13HdPyOat8+TghPL6Ewq2Wqt4WHkK+=jtJOZQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 20, 2020 at 4:29 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:

> Thanks. One thing I have considered while updating this patch was to
> write a test case similar to what we have for spilled stats in
> test_decoding/sql/stats.sql but I decided not to do it as that doesn't
> seem to add much value for the streaming case because we already have
> some tests in test_decoding/sql/stream.sql which indicates that the
> streaming is happening. If we could have a way to get the exact
> streaming stats then it would have been better but while writing tests
> for spilled stats we found that it is not possible because some
> background transactions (like autovacuum) might send the stats earlier
> making the actual number inconsistent. What do you think?
>

I agree. If the stat numbers can't be guaranteed to be consistent it's
not worth writing specific tests for this.

regards,
Ajin Cherian
Fujitsu Australia

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2020-10-22 06:14:32 Re: [Patch] Optimize dropping of relation buffers using dlist
Previous Message Thomas Munro 2020-10-22 05:54:43 Re: [Patch] Optimize dropping of relation buffers using dlist