Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: Shubham Khanna <khannashubham1197(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.
Date: 2025-03-10 05:34:21
Message-ID: CAFPTHDaww5BRCQ4MH9Bitp3puWu_wwryf-3GWxRJDA2Vud7feg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 10, 2025 at 3:58 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> On Thu, Mar 6, 2025 at 9:18 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
>
> > + Subscription names, publication names, and replication slot names are
> > + automatically generated. Cannot be used together with
> > + <option>--database</option>, <option>--publication</option>,
> > + <option>--replication-slot</option> or <option>--subscription</option>.
> >
> > Don't start the sentence with "Cannot". Change the sentence to "This
> > option cannot be used together with ..."
> > similar sentences used in 3 other places below this as well. Change all of them.
>
> I didn't find any instance of "Cannot be" in the *.sgml files, but I
> find some instances of "Can be". So it seems we allow such constructs
> in the documentation. Any reasons for suggesting this change?
>

I just don't think it is correct English to start a sentence with
"Cannot be". I checked with grammarly as well.

regards,
Ajin Cherian
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2025-03-10 05:35:22 Re: vacuumdb changes for stats import/export
Previous Message Michael Paquier 2025-03-10 05:25:28 Re: Back-patch of: avoid multiple hard links to same WAL file after a crash