| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Markus Wanner <markus(at)bluegap(dot)ch>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] add concurrent_abort callback for output plugin |
| Date: | 2021-03-31 09:09:58 |
| Message-ID: | CAFPTHDacfWdbM9Zgbfv+DuYh=-Au+KPSc8VDqpkdRxHBg9zVbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 31, 2021 at 5:25 PM Markus Wanner <
markus(dot)wanner(at)enterprisedb(dot)com> wrote:
>
> The last sentences there now seems to relate to just the setting of
> "concurrent_abort", rather than the whole reason to invoke the
> prepare_cb. And the reference to the "gid" is a bit lost. Maybe:
>
> "Thus even in case of a concurrent abort, enough information is
> provided to the output plugin for it to properly deal with the
> <command>ROLLBACK PREPARED</command> once that is decoded."
>
> Alternatively, state that the gid is otherwise missing earlier in the
> docs (similar to how the commit message describes it).
>
>
> I'm fine with Amit's changes and like Markus's last suggestion as well.
regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2021-03-31 09:18:52 | Re: Idea: Avoid JOINs by using path expressions to follow FKs |
| Previous Message | Ajin Cherian | 2021-03-31 09:04:56 | Re: locking [user] catalog tables vs 2pc vs logical rep |