| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
| Date: | 2021-07-09 06:56:28 |
| Message-ID: | CAFPTHDaSCG6pCzDxWLrAD3=pkz878agHxuiyXgxL9Xzu6QXWFA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 9, 2021 at 9:13 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> I tried the v95-0001 patch.
>
> - The patch applied cleanly and all build / testing was OK.
> - The documentation also builds OK.
> - I checked all v95-0001 / v93-0001 differences and found no problems.
> - Furthermore, I noted that v95-0001 patch is passing the cfbot [1].
>
> So this patch LGTM.
>
Applied, reviewed and tested the patch.
Also ran a 5 level cascaded standby setup running a modified pgbench
that does two phase commits and it ran fine.
Did some testing using empty transactions and no issues found
The patch looks good to me.
regards,
Ajin Cherian
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2021-07-09 07:15:08 | Re: [PATCH] expand the units that pg_size_pretty supports on output |
| Previous Message | Drouvot, Bertrand | 2021-07-09 06:51:34 | [bug] Logical Decoding of relation rewrite with toast does not reset toast_hash |