| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Truncate in synchronous logical replication failed |
| Date: | 2021-04-20 01:52:43 |
| Message-ID: | CAFPTHDaAjR7F86MJ7eOprXMekEpV21gMSfZW_58t+c+cAOzysw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 17, 2021 at 2:04 PM osumi(dot)takamichi(at)fujitsu(dot)com <
osumi(dot)takamichi(at)fujitsu(dot)com> wrote:
>
> No problem. Thank you for updating the patch.
> I've conducted some cosmetic changes. Could you please check this ?
> That's already applied by pgindent.
>
> I executed RT for this and made no failure.
> Just in case, I executed 010_truncate.pl test 100 times in a tight loop,
> which also didn't fail.
>
>
I reviewed the patch, ran make check, no issues. One minor comment:
Could you add the comment similar to RelationGetIndexAttrBitmap() on why
the redo, it's not very obvious
to someone reading the code, why we are refetching the index list here.
+ /* Check if we need to redo */
+ newindexoidlist = RelationGetIndexList(relation);
thanks,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2021-04-20 01:58:04 | Re: ANALYZE counts LP_DEAD line pointers as n_dead_tup |
| Previous Message | Julien Rouhaud | 2021-04-20 01:49:08 | Re: Bogus collation version recording in recordMultipleDependencies |