From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
Date: | 2021-05-15 14:07:02 |
Message-ID: | CAFPTHDa6tPiAtnRRvtqsHVf3zVoT6FC8XnanZSk0SLUWvmnDGQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, May 13, 2021 at 7:50 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Please find attached the latest patch set v75*
>
> Differences from v74* are:
>
> * Rebased to HEAD @ today.
>
> * v75 also addresses some of the feedback comments from Vignesh [1].
Adding a patch to this patch-set that avoids empty transactions from
being sent to the subscriber/replica. This patch is based on the
logic that was proposed for empty transactions in the thread [1]. This
patch uses that patch and handles empty prepared transactions
as well. So, this will avoid empty prepared transactions from being
sent to the subscriber/replica. This patch also avoids sending
COMMIT PREPARED /ROLLBACK PREPARED if the prepared transaction was
skipped provided the COMMIT /ROLLBACK happens
prior to a restart of the walsender. If the COMMIT/ROLLBACK PREPARED
happens after a restart, it will not be able know that the
prepared transaction prior to the restart was not sent, in this case
the apply worker of the subscription will check if a prepare of the
same type exists
and if it does not, it will silently ignore the COMMIT PREPARED
(ROLLBACK PREPARED logic was already doing this).
Do have a look and let me know if you have any comments.
regards,
Ajin Cherian
Fujitsu Australia.
Attachment | Content-Type | Size |
---|---|---|
v76-0001-Add-support-for-prepared-transactions-to-built-i.patch | application/octet-stream | 145.1 KB |
v76-0002-Add-prepare-API-support-for-streaming-transactio.patch | application/octet-stream | 53.7 KB |
v76-0003-Skip-empty-transactions-for-logical-replication.patch | application/octet-stream | 20.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ranier Vilela | 2021-05-15 14:35:13 | Re: Possible memory corruption (src/timezone/zic.c b/src/timezone/zic.c) |
Previous Message | Bruce Momjian | 2021-05-15 14:00:25 | Re: compute_query_id and pg_stat_statements |