| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Hubert Lubaczewski <depesz(at)depesz(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Excessive number of replication slots for 12->14 logical replication |
| Date: | 2022-08-18 03:44:12 |
| Message-ID: | CAFPTHDZQ1wGbs08hMb_jG9aeOWQT68qRi_qg7YoCxxeJUHaniA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Aug 18, 2022 at 12:40 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Thu, Aug 18, 2022 at 11:38 AM Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
> > On Thu, Aug 18, 2022 at 10:50 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> > >
> > > Ajin Cherian, do you want to update the patch according to these
> > > comments? or shall I?
> > >
> > > Regards,
> > >
> >
> > I will create a patch for this in a short while.
>
> Great, thanks!
>
> Regards,
>
Attached a patch with the changes. In DropSubscription(), I have let
GetSubscriptionRelations()
filter the READY state relations but added a check for !SYNCDONE state
while cleaning up origin
tracking. This matches with the logic used for clean-up of tablesync
slots below in the same function.
regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v8-0001-fix-excessive-replication-origin-slots-issue.patch | application/octet-stream | 6.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-08-18 05:45:47 | Re: Excessive number of replication slots for 12->14 logical replication |
| Previous Message | Masahiko Sawada | 2022-08-18 02:39:34 | Re: Excessive number of replication slots for 12->14 logical replication |