| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Hubert Lubaczewski <depesz(at)depesz(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Excessive number of replication slots for 12->14 logical replication |
| Date: | 2022-08-18 05:58:01 |
| Message-ID: | CAFPTHDYbMLxTga3aBYE8pOPgk0K4L44FMz2LokB16PmE4LU=Wg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Aug 18, 2022 at 3:46 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> Looks good.
>
> I have one minor comment:
>
> - * SUBREL_STATE_FINISHEDCOPY. The apply worker can also
> - * concurrently try to drop the origin and by this time
> - * the origin might be already removed. For these reasons,
> - * passing missing_ok = true.
> + * SUBREL_STATE_FINISHEDCOPY. So passing missing_ok = true.
>
> I think we should change "the apply worker" to "the tablesync worker"
> but should not remove this sentence. The fact that another process
> could concurrently try to drop the origin is still true.
>
> The rest looks good to me.
>
Updated as described.
regards,
Ajin Cherian
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v9-0001-fix-excessive-replication-origin-slots-issue.patch | application/octet-stream | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2022-08-18 10:30:29 | Re: Excessive number of replication slots for 12->14 logical replication |
| Previous Message | Masahiko Sawada | 2022-08-18 05:45:47 | Re: Excessive number of replication slots for 12->14 logical replication |