| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Hubert Lubaczewski <depesz(at)depesz(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Excessive number of replication slots for 12->14 logical replication |
| Date: | 2022-08-12 05:42:35 |
| Message-ID: | CAFPTHDYRHkgaNqgkNH62-mo1-vb1w-aFfnzZMGpvUzedxqmggQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Aug 12, 2022 at 3:22 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> ISTM that the "This" in the first sentence in the second paragraph
> still indicates the cleanup of the origin tracking and table sync
> slot. How about not having the common comment for both like the patch
> I've attached? In addition to this change, I moved the code to drop
> the origin before stopping the streaming so that it can be close to
> the slot drop. But feel free to revert this change.
>
This looks fine to me.
regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Bug reporting form | 2022-08-12 06:24:55 | BUG #17583: Server crashes on executing CROSS JOIN with very big number of tables |
| Previous Message | Masahiko Sawada | 2022-08-12 05:21:56 | Re: Excessive number of replication slots for 12->14 logical replication |