Re: [pgAdmin4][Patch]: RM #1978 - Add an option to allow user to disable alertifyjs and acitree animations

Hi Dave,

On Tue, Apr 3, 2018 at 7:23 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> Thanks - I've committed this, however, could you send me an updated
> screenshot for the docs? The one you sent was a different size and colour
> depth from the others (and looked like a different scale).
>
> Please find the attached patch for the same.

> On Tue, Apr 3, 2018 at 10:42 AM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>> On Thu, Mar 29, 2018 at 6:54 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Hi
>>>
>>> On Thu, Mar 29, 2018 at 1:51 PM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>>
>>>>
>>>> On Mon, Mar 26, 2018 at 6:07 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>>> Hi
>>>>>
>>>>> On Mon, Mar 26, 2018 at 7:23 AM, Khushboo Vashi <
>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch to fix RM #1978: Add an option to
>>>>>> allow user to disable alertifyjs and acitree animations.
>>>>>>
>>>>>
>>>>> I think these really need to be per-user settings, not
>>>>> per-installation.. Whether or not animations are shown is really a matter
>>>>> of personal taste and circumstance.
>>>>>
>>>>> Right, it should be per-user settings. Please find the attached
>>>> updated patch.
>>>>
>>>
>>> I found some issues I'm afraid:
>>>
>>> - The label "Enable dialogues/notifications animation?" should read
>>> "Enable dialogue/notification animation?"
>>>
>>> Changed.
>>
>>> - Disabling treeview animation only seems to affect the main browser
>>> treeview, and not others in the application (e.g. the one on the
>>> Preferences panel).
>>>
>>> Fixed
>>
>>> - After disabling dialogue/notification animations, I cannot re-enable
>>> notification animations. If I flip the switch back on, dialogue animations
>>> immediately start working again, but notification animations don't even
>>> work following a reload.
>>>
>>> Fixed.
>>
>>> Thanks.
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>> Thanks,
>> Khushboo
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Thanks,
Khushboo