Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #3135 - [Web based] Syntax error displayed when user try to insert data on table where primray key is in captial letters and table contains OIDS
Date: 2018-03-06 12:33:15
Message-ID: CAFOhELfeb=nH7dDHmEpd7L+FsiqyOJB921PuHMrmJ-uQJy_7kA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Joao,

Thanks for reviewing.

On Thu, Mar 1, 2018 at 8:06 PM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:

> Hello Kushboo,
>
> Can we add some Unit test to ensure this does not happen again?
>
> Please find the attached patch with the unit tests.

> Thanks
> Joao
>
> Thanks,
Khushboo

> On Thu, Mar 1, 2018 at 2:28 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM # 3135 - [Web based] Syntax
>> error displayed when user try to insert data on table where primray key is
>> in captial letters and table contains OIDS
>>
>> Thanks,
>> Khushboo
>>
>

Attachment Content-Type Size
RM_3135_ver1.patch text/x-patch 10.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Joao De Almeida Pereira 2018-03-06 14:55:49 Re: pgAdmin 4 commit: Support for external tables in GPDB. Fixes #3168
Previous Message Khushboo Vashi 2018-03-06 10:09:44 Re: pgAdmin 4 commit: Ensure we pick up the messages from the current query