Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Anthony Emengo <aemengo(at)pivotal(dot)io>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript
Date: 2018-05-17 05:35:47
Message-ID: CAFOhELfbA-7+kYATQMm4jLgb77B_yxBVH1u5VJ8ij9-Ms8fNjg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Anthony,

The code looks good to me and working fine.

Thanks,
Khushboo

On Wed, May 16, 2018 at 9:23 PM, Anthony Emengo <aemengo(at)pivotal(dot)io> wrote:

> Hey all, we'd definitely like some feedback on this patch. Does does it
> not apply cleanly? Do we need to resend it?
>
> Thanks
> Anthony
>
> On Mon, May 14, 2018 at 3:47 PM Anthony Emengo <aemengo(at)pivotal(dot)io> wrote:
>
>> Apologies, here's a redo that should apply cleanly on top of master
>>
>> Anthony && Joao
>>
>> On Mon, May 14, 2018 at 3:25 PM Anthony Emengo <aemengo(at)pivotal(dot)io>
>> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached you can find a patch that changes the way we are running ESLint
>>> on the Javascript files. Instead of using Javascript we can use ESLint
>>> parameters to archive the same goal.
>>>
>>> In the future this will also allow us to use the rest of the cli
>>> parameters like (--fix and others...)
>>>
>>> Thanks
>>> Anthony && Joao
>>>
>>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Ashesh Vashi 2018-05-17 06:23:52 pgAdmin 4 commit: Using the '.eslintignore' config file for excluding t
Previous Message Anthony Emengo 2018-05-16 15:53:20 Re: [pgadmin4][patch] Use ESLinter options instead of using Javascript