| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com> |
| Cc: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch for SonarQube UI fixes. |
| Date: | 2020-06-15 11:15:45 |
| Message-ID: | CAFOhELfYZ0DHEL81rH-hpgmQgcwxb5wt7=CtMgpN-qV8_Pdi0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:
> Hi,
>
> The patch looks good to me.
>
I think the dashboard.js fix is not accurate as when you return something
you have to assign that value to any variable.
>
> On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Team,
>>
>> I have fixed some UI related issues of SonarQube scan.
>> Mainly fixes are related to removing duplicate properties in css class
>> and few js standard syntax fixes.
>> PFA patch.
>>
>
>
> --
> Thanks and Regards,
> Aditya Toshniwal
> pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
> "Don't Complain about Heat, Plant a TREE"
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2020-06-15 11:18:14 | Re: Patch for SonarQube UI fixes. |
| Previous Message | Dave Page | 2020-06-15 11:13:14 | Re: [pgAdmin][patch] Runtime fixes reported by SonarQube |