Re: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions
Date: 2018-02-19 13:27:15
Message-ID: CAFOhELfSL6cdjzsGXA=Fmpr8g8=dUKqt-ejXxH9cBddTc69uXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Mon, Feb 19, 2018 at 5:19 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Mon, Feb 19, 2018 at 7:56 AM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix RM #3066 - Create script doesn't
>> add quotation marks to column names for the "add index" functions
>>
>
> This causes additional quoting on regular tables. Please see the generated
> SQL for the index below:
>
> Please find the attached updated patch.

> -- Table: public."CamelCase"
>
> -- DROP TABLE public."CamelCase";
>
> CREATE TABLE public."CamelCase"
> (
> "ID" bigint NOT NULL DEFAULT nextval('"CamelCase_ID_seq"'::regclass),
> "SomeColumn" text COLLATE pg_catalog."default",
> b boolean,
> CONSTRAINT "CamelCase_pkey" PRIMARY KEY ("ID")
> )
> WITH (
> OIDS = FALSE
> )
> TABLESPACE pg_default;
>
> ALTER TABLE public."CamelCase"
> OWNER to postgres;
>
> -- Index: MixedCase_IDX
>
> -- DROP INDEX public."MixedCase_IDX";
>
> CREATE INDEX "MixedCase_IDX"
> ON public."CamelCase" USING btree
> ("""ID""")
> TABLESPACE pg_default;
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
RM_3066_ver1.patch text/x-patch 739 bytes

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2018-02-19 16:30:47 pgAdmin 4 commit: Python 3 fix for the runtime.
Previous Message Dave Page 2018-02-19 11:49:01 Re: [pgAdmin4][Patch]: RM #3066 - Create script doesn't add quotation marks to column names for the "add index" functions