Re: [pgAdmin4][Patch] - RM 3009 - Right click to copy from data grid, optionally with headers.

On Thu, Sep 26, 2019 at 2:36 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Khushboo
>
> Found one minor issue "Header row should get unhighlighted when we
> deselect 'Copy with headers' and select some new row or deselect any
> existing selected row."
> [image: Screenshot 2019-09-26 at 2.32.43 PM.png]
>
> Fixed, please find the attached updated patch.

> Apart from that code looks good to me.
>
> On Thu, Sep 26, 2019 at 10:51 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>> On Mon, Sep 23, 2019 at 3:16 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Khushboo
>>>
>>> Following are the review comments:
>>>
>>> - Copy with headers not working when we select a few rows.
>>>
>>> Fixed
>>
>>>
>>> - The dropdown should be disabled when the copy button is disabled.
>>> - When user select/de-select "Copy with headers" option dropdown
>>> should not be closed. It should be consistent with "Auto Commit/Rollback"
>>> or explain options.
>>>
>>> Fixed
>>
>>>
>>> - Feature test "CopySelectedQueryResultsFeatureTest" failed on my
>>> machine.
>>>
>>> Fixed.
>>
>> Thanks,
>> Khushboo
>>
>>>
>>> - Documentation changes are required, update the screenshot wherever
>>> applicable.
>>>
>>>
>>> On Mon, Sep 23, 2019 at 11:42 AM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch for RM #3009 - Right click to copy from
>>>> data grid, optionally with headers.
>>>>
>>>> Query Tool / View data:
>>>>
>>>> Currently the result-set can be copied without header. With this patch
>>>> the result-set can be copied with the header also and that is optional.
>>>>
>>>> To copy the result-set with header, the option '*Copy with header'* is
>>>> given next with the Copy button in the toolbar in the form of dropdown.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>