Re: pgAdmin 4 commit: Fix naming inconsistency for the column and FTS parse

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgAdmin 4 commit: Fix naming inconsistency for the column and FTS parse
Date: 2019-03-15 05:27:56
Message-ID: CAFOhELfDRjs0P99axauY8YwU_jRBavy0TY5TRfqQp8zBmXORnw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the attach fix for the regression.

Thanks,
Khushboo

On Thu, Mar 14, 2019 at 10:23 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Fix naming inconsistency for the column and FTS parser modules. Fixes #1269
>
> Branch
> ------
> master
>
> Details
> -------
>
> https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=69ec460b6024c3deaa5616455ebd81d32abfeded
>
> Modified Files
> --------------
> docs/en_US/release_notes_4_4.rst | 1 +
> .../schemas/fts_configurations/tests/test_fts_configuration_add.py | 2
> +-
> .../servers/databases/schemas/{fts_parser => fts_parsers}/__init__.py | 0
> .../{fts_parser => fts_parsers}/static/img/coll-fts_parser.svg | 0
> .../schemas/{fts_parser => fts_parsers}/static/img/fts_parser.svg | 0
> .../schemas/{fts_parser => fts_parsers}/static/js/fts_parser.js | 0
> .../templates/fts_parser/sql/default/create.sql | 0
> .../templates/fts_parser/sql/default/delete.sql | 0
> .../templates/fts_parser/sql/default/functions.sql | 0
> .../templates/fts_parser/sql/default/nodes.sql | 0
> .../templates/fts_parser/sql/default/properties.sql | 0
> .../templates/fts_parser/sql/default/schema.sql | 0
> .../templates/fts_parser/sql/default/sql.sql | 0
> .../templates/fts_parser/sql/default/update.sql | 0
> .../databases/schemas/{fts_parser => fts_parsers}/tests/__init__.py | 0
> .../schemas/{fts_parser => fts_parsers}/tests/test_fts_parser_add.py | 0
> .../{fts_parser => fts_parsers}/tests/test_fts_parser_delete.py | 0
> .../tests/test_fts_parser_delete_multiple.py | 0
> .../schemas/{fts_parser => fts_parsers}/tests/test_fts_parser_get.py | 0
> .../schemas/{fts_parser => fts_parsers}/tests/test_fts_parser_put.py | 0
> .../databases/schemas/{fts_parser => fts_parsers}/tests/utils.py | 0
> .../servers/databases/schemas/tables/{column => columns}/__init__.py | 0
> .../schemas/tables/{column => columns}/static/img/coll-column.svg | 0
> .../schemas/tables/{column => columns}/static/img/column.svg | 0
> .../databases/schemas/tables/{column => columns}/static/js/column.js | 0
> .../{column => columns}/templates/column/macros/privilege.macros | 0
> .../{column => columns}/templates/column/macros/security.macros | 0
> .../databases/schemas/tables/{column => columns}/tests/__init__.py | 0
> .../schemas/tables/{column => columns}/tests/test_column_add.py | 0
> .../schemas/tables/{column => columns}/tests/test_column_delete.py | 0
> .../tables/{column => columns}/tests/test_column_delete_multiple.py | 0
> .../schemas/tables/{column => columns}/tests/test_column_get.py | 0
> .../schemas/tables/{column => columns}/tests/test_column_msql.py | 0
> .../schemas/tables/{column => columns}/tests/test_column_put.py | 0
> .../databases/schemas/tables/{column => columns}/tests/utils.py | 0
> .../databases/schemas/tables/indexes/tests/test_indexes_delete.py | 2
> +-
> .../schemas/tables/indexes/tests/test_indexes_delete_multiple.py | 2
> +-
> .../databases/schemas/tables/indexes/tests/test_indexes_get.py | 2
> +-
> .../databases/schemas/tables/indexes/tests/test_indexes_put.py | 2
> +-
> .../servers/databases/schemas/views/children/__init__.py | 4
> ++--
> 40 files changed, 8 insertions(+), 7 deletions(-)
>
>

Attachment Content-Type Size
regression_fix.patch application/octet-stream 2.6 KB

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-03-15 09:09:29 pgAdmin 4 commit: Fix node paths that I broke yesterday.
Previous Message Dave Page 2019-03-14 16:52:46 pgAdmin 4 commit: Fix naming inconsistency for the column and FTS parse