| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Nico Rikken <nico(dot)rikken(at)alliander(dot)com> |
| Cc: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>, "pgadmin-hackers(at)lists(dot)postgresql(dot)org" <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [pgAdmin][PATCH] Add OAUTH2_SCOPE variable for scope configuration |
| Date: | 2021-08-31 08:31:46 |
| Message-ID: | CAFOhELf41dmUs0vPWNoXtL6u9CGZEpzu8FzLFNDqaAG769yxpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Tue, Aug 31, 2021 at 1:25 PM Nico Rikken <nico(dot)rikken(at)alliander(dot)com>
wrote:
> Thanks for reviewing. Indeed this is a bandaid to expand the usability of
> the OAuth implementation. As I've written on the redmine issue as well
> https://redmine.postgresql.org/issues/6627 I've tested my usecase with a
> modified scope by patching the oauth2.py file in production. That works
> well for authentication from Microsoft Azure AD. Also Shy N reported this
> method to work.
Good to hear that.
> This patch just makes the scope configurable so it can be adopted to
> different use-cases.
Thanks for working on this. :)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2021-08-31 08:39:12 | pgAdmin 4 commit: Fixed an issue where Revoke all is not displayed if t |
| Previous Message | Nikhil Mohite | 2021-08-31 08:29:29 | Re: [pgAdmin][RM-4567]: Privileges revoked using SQL query on objects like tables does not correctly in SQL tab |