| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime |
| Date: | 2017-06-13 06:07:04 |
| Message-ID: | CAFOhELepWUpQh5jDCJz-JZzAtTs6RGVNnvLSNrRe_i+LOWv4qQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
On Mon, Jun 12, 2017 at 5:27 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Hi
>
> On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi
> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > Please find the attached patch to reset the zoom level in the desktop
> > runtime.
> >
> > Added the new shortcut CTRL + 0 to reset the zoom level.
>
> The code looks good, however I don't think resetting to the startup
> value is really what we want. Shouldn't it reset it to 1.0?
>
> I have changed the code.
Also, introduced a single slot for Zoom In/Out/Reset rather than 3
different.
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| Attachment | Content-Type | Size |
|---|---|---|
| runtime_reset_zoom_ver1.patch | text/x-patch | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2017-06-13 06:18:05 | pgAdmin 4 commit: Using client-side 'url_for' implementation in the Gra |
| Previous Message | pgAdmin 4 Jenkins | 2017-06-13 05:38:26 | Build failed in Jenkins: pgadmin4-master-python27 #164 |