Re: [pgAdmin4] [Patch]: Foreign Table Module

Hi,

Please find the attached updated patch for the Foreign Table module.

Thanks,
Khushboo

On Tue, May 10, 2016 at 4:33 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

>
>
> On Mon, May 9, 2016 at 1:23 PM, Ashesh Vashi <
> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> On Mon, May 9, 2016 at 5:50 PM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached updated patch for the Foreign Tables module.
>>>
>>
> Feedback from my initial testing:
>
> - Owner is missing from the New dialogue.
>
> Done

> - The Properties list shows "Select from the list" in a combo box for
> Owner and
> Inherits.
>

>
>
This is a generalize issue, I will create a new Kanban card for the same.

> - s/Oid/OID
>
> Done

> - s/Foreign Server/Foreign server
>
> Done

> - SQL Help filenames are not defined.
>
> Done

> - SQL formatting is weird, e.g.
>
> CREATE FOREIGN TABLE public.redis_table
> (id text NOT NULL COLLATE pg_catalog."default",
> value text NULL COLLATE pg_catalog."default")
> SERVER redis_server1
> OPTIONS (database '0');
>
> instead of:
>
> CREATE FOREIGN TABLE public.redis_table (
> id text NOT NULL COLLATE pg_catalog."default",
> value text NULL COLLATE pg_catalog."default"
> )
> SERVER redis_server1
> OPTIONS (database '0');
>
>
Done

> - In the validation error messages, please replace ! with . and "can not"
> with
> "cannot" for consistency with recently reviewed strings.
>
>
Done

> - s/mulitple/multiple (in the js).
>
> Done

> - How do I manage the ACL?
>
> Done. I missed this as I was following pgAdmin-3 as usual.

> Thanks.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>