Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.
Date: 2020-04-10 06:28:00
Message-ID: CAFOhELeQiDhuATRuzxaXGUsbrabiPX23MKx0x2NtJEmD_QkCvg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the attached updated patch.

Thanks,
Khushboo

On Fri, Apr 10, 2020 at 10:41 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Akshay,
>
> On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Hi Khushboo
>>
>> Schema Diff test cases are failing with this patch. Please fix and resend
>> the patch.
>>
>> Fixed.

Thanks,
Khushboo

> Can you please re-verify as I don't think schema diff test cases are
> failing due to this patch.
>
> Thanks,
> Khushboo
>
>> On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym
>>> properties does not show OID.
>>>
>>> As per the current implementation, we completely ignored OID and instead
>>> considered the name as the unique field, now with this patch OID will be
>>> used as an unique id and also will display OID in the properties tab.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>>
>> *Sr. Software Architect*
>> *EnterpriseDB Software India Private Limited*
>> *Mobile: +91 976-788-8246*
>>
>

Attachment Content-Type Size
RM_5270_v1.patch application/octet-stream 21.0 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-04-10 08:47:11 Re: [pgAdmin4][RM#2813] Do not prompt for database server password once user saves it
Previous Message Aditya Toshniwal 2020-04-10 06:18:52 [pgAdmin][RM4969] JSONB and JSON field editing