From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: [pgAdmin4][Patch]: Added the shortcut (CTRL + 0) to reset the zoom level in runtime |
Date: | 2017-06-13 09:36:09 |
Message-ID: | CAFOhELeOXuaRAjXmS_6vMAJNFVDX7aoi_zBqbmtjUuMv3YCbQA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
On Tue, Jun 13, 2017 at 2:52 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> Nice work! Committed (along with an update to the docs).
>
> Congratulations on your first C++ patch :-)
>
> Thanks Dave. :)
> On Tue, Jun 13, 2017 at 7:07 AM, Khushboo Vashi
> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > On Mon, Jun 12, 2017 at 5:27 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> >>
> >> Hi
> >>
> >> On Mon, Jun 12, 2017 at 5:33 AM, Khushboo Vashi
> >> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> >> > Hi,
> >> >
> >> > Please find the attached patch to reset the zoom level in the desktop
> >> > runtime.
> >> >
> >> > Added the new shortcut CTRL + 0 to reset the zoom level.
> >>
> >> The code looks good, however I don't think resetting to the startup
> >> value is really what we want. Shouldn't it reset it to 1.0?
> >>
> > I have changed the code.
> > Also, introduced a single slot for Zoom In/Out/Reset rather than 3
> > different.
> >>
> >> --
> >> Dave Page
> >> Blog: http://pgsnake.blogspot.com
> >> Twitter: @pgsnake
> >>
> >> EnterpriseDB UK: http://www.enterprisedb.com
> >> The Enterprise PostgreSQL Company
> >
> >
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
From | Date | Subject | |
---|---|---|---|
Next Message | Ashesh Vashi | 2017-06-13 10:13:41 | pgAdmin 4 commit: Required mock package for python < 3.3. |
Previous Message | pgAdmin 4 Jenkins | 2017-06-13 09:33:40 | Build failed in Jenkins: pgadmin4-master-python26 #287 |