| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React |
| Date: | 2019-03-07 11:07:37 |
| Message-ID: | CAFOhELeKM=ghqt9VNO7A5etZ3L_U3w1hu=XQ4LbcBaPPZksM9A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Thu, Mar 7, 2019 at 4:34 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>
> On Thu, Mar 7, 2019 at 11:02 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>>
>> On Thu, Mar 7, 2019 at 4:23 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>
>>> Thanks - committed. Oddly, having removed a bunch of files and 88 JS
>>> dependencies, the resulting Python package is actually slightly bigger!
>>>
>> And now I have conflicts in around 40 files. :)
>>
>
> Oops. Sorry about that :-(
>
> But there are now 88 fewer dependencies to update, so you're 110% better
> off than you were :-D
>
And that's the reason, I have asked Aditya, to send the patch as soon as it
is ready, so I can work on top of that. :)
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aditya Toshniwal | 2019-03-07 12:10:34 | [pgAdmin4][RM4054] Wrong Message displayed on Query tool window if user create table without column |
| Previous Message | Dave Page | 2019-03-07 11:04:05 | Re: [pgAdmin4][RM4018] Technical debt: Rewrite the Query Tool history and related tests to remove dependency on React |