Re: [pgAdmin4][Patch]: Fix RM #3191 : Debug option is not working

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Fix RM #3191 : Debug option is not working
Date: 2018-07-11 07:03:13
Message-ID: CAFOhELeBoxrKfPQfpv73XN820gQMjvnS2=Li6vzpJD-bE1tDxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Please find the attached updated patch with PEP8 fixes.

On Wed, Jul 11, 2018 at 11:18 AM, Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi,
>
> Please find the attached patch to fix #3191 : Debug option is not working.
>
> Issues fixed:
>
> 1. EPAS packages' function/procedure does not honour INOUT arguments, it
> converts INOUT to OUT.
>
> 2. Packages' functions and procedures are not getting listed in their
> respected nodes in some scenarios like procedure having INOUT argument and
> function with void return type
>
> 3. The Reverse engineering SQL is not correct for Packages'
> functions/procedures
>
> 4. In case of INOUT argument, debugger asks for mendatory input which
> should not.
>
>
> Thanks,
> Khushboo
>

Attachment Content-Type Size
RM_3191_v1.patch text/x-patch 48.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2018-07-11 07:03:38 Re: Regarding RM #3316 Pgadmin4 No Tray Crash
Previous Message Ashesh Vashi 2018-07-11 05:53:56 pgAgent commit: Using mutex around the logging functionality to avoid l