Re: Bug in Database Nodes in the Tree

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Yosry Muhammad <yosrym93(at)gmail(dot)com>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Bug in Database Nodes in the Tree
Date: 2019-07-18 05:27:21
Message-ID: CAFOhELe=SxTy0mBMHOoKE+EfHVVDR0E_az2B7EkGvRaPQvowFQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Yosry,

On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <yosrym93(at)gmail(dot)com> wrote:

> Hi Khushboo,
>
> There's a minor bug that I noticed a while back that when you right click
> a disconnected database (to drop it for example) it automatically connects
> to the database and expands the node. This behaviour is a little annoying
> to users (me too), I am trying to fix it.
>
> This behavior is by design as we have considered some of the pgAdmin
III behavior. One behavior we can change is that on the selection of the
database node, we can just connect it and not expand it and when we expand
the database node (by arrow icon or double click), we can connect and
expand both.

We need Dave's approval to change this.

I looked around the code in the browser module (node.js, database.js,
> menu.js) and I couldn't find a way to modify this behaviour. Is this
> handled internally by jQuery? Is modifying this behaviour feasible?
>
>
I think the problem is that the right click event triggers the left event
> click too. Am I correct?
>
> Basically, the browser tree is generated through the aciTree library, so
when required, the public APIs (provided by aciTree) of the events are
being called.
In this case, on the selection of the database node, the selected event is
used in the database.js file.

Thanks,
Khushboo

Thanks!
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Yosry Muhammad 2019-07-18 05:40:40 Re: Bug in Database Nodes in the Tree
Previous Message Yosry Muhammad 2019-07-17 17:18:50 Bug in Database Nodes in the Tree