Re: [pgAdmin4][Patch]: Partition table fix

Hi,

On Fri, Jul 20, 2018 at 9:31 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Fri, Jul 20, 2018 at 10:42 AM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix the issue : The right panels
>> (properties, SQL etc...) give error while clicking on the partitions of a
>> table.
>>
>
> This fails tests for me:
>
Please find the attached patch with fix.

Initially we have made partitions as a child of table but later partitions
node was brought up to the table level and that was broken. So, I have made
it same as initial approach.
The jasmine test cases are updated for the same.

>
> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 304 of 741 SUCCESS (0
> secs / 4.711 secs)
>
> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) tree#node#getTreeNodeHierarchy
> getTreeNodeHierarchy is called with aciTreeNode object When tree has table
> when table has partition returns table with partition parameters FAILED
>
> Expected object not to have properties
>
> partition: Object({ some key: 'expected value', _type: 'partition',
> some other key: 'some other value', priority: 0 })
>
> at UserContext.<anonymous> (regression/javascript/tree/
> webpack:/regression/javascript/tree/pgadmin_tree_node_spec.js:177:26)
>
> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 680 of 741 (1 FAILED)
> (0 secs / 6.981 secs)
>
> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) tree#node#getTreeNodeHierarchy
> getTreeNodeHierarchy is called with aciTreeNode object When tree has table
> when table has partition returns table with partition parameters FAILED
>
> Expected object not to have properties
>
> partition: Object({ some key: 'expected value', _type: 'partition',
> some other key: 'some other value', priority: 0 })
>
> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) tree#node#getTreeNodeHierarchy
> getTreeNodeHierarchy is called with TreeNode object When tree has table
> when table has partition returns table with partition parameters FAILED
>
> Expected object not to have properties
>
> partition: Object({ some key: 'expected value', _type: 'partition',
> some other key: 'some other value', priority: 0 })
>
> at UserContext.<anonymous> (regression/javascript/tree/
> webpack:/regression/javascript/tree/pgadmin_tree_node_spec.js:336:26)
>
> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 686 of 741 (2 FAILED)
> (0 secs / 6.999 secs)
>
> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) tree#node#getTreeNodeHierarchy
> getTreeNodeHierarchy is called with TreeNode object When tree has table
> when table has partition returns table with partition parameters FAILED
>
> Expected object not to have properties
>
> partition: Object({ some key: 'expected value', _type: 'partition',
> some other key: 'some other value', priority: 0 })
>
> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 741 of 741 (2 FAILED)
> (7.47 secs / 7.149 secs)
>
> error Command failed with exit code 1.
>
> info Visit *https://yarnpkg.com/en/docs/cli/run
> <https://yarnpkg.com/en/docs/cli/run>* for documentation about this
> command.
>
> make: *** [check] Error 1
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>