Re: [pgadmin4][Patch]: RM #3122 - Backup not working on certificate (SSL) protected servers

On Thu, Mar 15, 2018 at 3:21 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Mar 14, 2018 at 10:55 AM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>
> Can you add a unit test for set_env_variables() please?
>
>
This function is a part of a BatchProcess class which is used by all
backup/restore/maintenance etc modules. So, when we write test cases for
this module this function will be covered.
I had already created RM for the same (Ref:
https://redmine.postgresql.org/issues/3206) and it is in the current sprint.

>
>> Thanks,
>> Khushboo
>>
>> On Wed, Mar 14, 2018 at 1:07 PM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>>
>>>
>>> On Wed, Mar 14, 2018 at 12:48 PM, Murtuza Zabuawala <
>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>
>>>> ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +310 without
>>>> your patch applied.
>>>>
>>>> Yes, good point. Will update and send the patch.
>>>
>>>>
>>>> On Wed, Mar 14, 2018 at 12:39 PM, Murtuza Zabuawala <
>>>> murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Khushboo,
>>>>>
>>>>> We can simplify this, we don't need to create any extra column,
>>>>>
>>>>> Check: ../pgadmin4/web/pgadmin/tools/import_export/__init__.py +322
>>>>> where we are setting ENV variable we can create common utility function
>>>>> (let say in ../tools/utils/__init__.py) which will set all required the
>>>>> environment variables and then we will pass that function in p.start(..)
>>>>> method.
>>>>>
>>>>>
>>>>> --
>>>>> Regards,
>>>>> Murtuza Zabuawala
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>>
>>>>> On Wed, Mar 14, 2018 at 11:03 AM, Khushboo Vashi <
>>>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please find the attached patch to fix RM #3122 : Backup not working
>>>>>> on certificate (SSL) protected servers.
>>>>>>
>>>>>> The attached patch fixes the issue in the following modules:
>>>>>>
>>>>>> 1. Backup
>>>>>> 2. Restore
>>>>>> 3. Import/Export
>>>>>> 4. Maintenance
>>>>>>
>>>>>> Thanks,
>>>>>> Khushboo
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>