Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Result grid rendering (was: Re: [pgAdmin4][Pattch] - RM #3673 - "Download as .csv" F8 does NOT work when one of joined files is a TEMPORARY file)
Date: 2019-02-27 05:52:15
Message-ID: CAFOhELdhD6XUS6MhLen3Gu4Wj-15wWgaVEOR_tR5J7iibMgh7Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

Please find the attached fix.
I have added the configurable option to add the extra classes in the
panel.js, so in the future, we can utilize it if required.

Here, I have added a class to hide the extra vertical scrollbar to the
Datagrid panel.

Thanks,
Khushboo

On Tue, Feb 26, 2019 at 7:08 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi Khushboo,
>
> On Wed, Feb 20, 2019 at 10:06 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>>
>> Also, the result grid seems to only be rendering itself to use about 50%
>>>> of the available vertical height now. Is that something messed up on my
>>>> system, or are you seeing it as well?
>>>>
>>>> This issue is the side effect of the Scratch Pad commit and has already
>>> been logged by Akshay. I will fix along with this RM.
>>>
>> Fixed.
>>
>
> I've started seeing weirdness with the Query Tool grid again. If I run
> View Data on a table with more rows than can be seen on screen at once, I
> get a double scrollbar. If I then resize the grid, the double scrollbar
> vanishes, but the grid re-renders incorrectly. Screenshots attached.
>
> Can you take a look please?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
data_grid_fix.patch application/octet-stream 2.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-02-27 07:08:52 Re: [pgAdmin4][RM3587] Browser rendering of a bigint in a jsonb is wrong
Previous Message Aditya Toshniwal 2019-02-27 04:42:14 Re: [pgAdmin4][RM3587] Browser rendering of a bigint in a jsonb is wrong