Re: [pgAdmin4][Patch]: RM 2089 - PARALLEL SAFE support for functions missing

Hi,

Please find the attached updated patch.

Thanks,
Khushboo

On Wed, Feb 15, 2017 at 8:57 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
wrote:

> Hi
>
> On Fri, Feb 10, 2017 at 7:28 AM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached updated patch.
>>
>> Thanks,
>> Khushboo
>>
>> On Fri, Feb 3, 2017 at 7:53 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
>> wrote:
>>
>>>
>>>
>>> On Fri, Feb 3, 2017 at 1:59 PM, Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>>
>>>>
>>>> On Fri, Feb 3, 2017 at 7:02 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
>>>> wrote:
>>>>
>>>>> I doubt the order matters, but feel free to change it if it bugs you
>>>>> :-)
>>>>>
>>>>>
>>>> I have tried to create the function with both SQL commands.
>>>> There is no bug, its just in pgAdmin4, if its not leakproof then we
>>>> mentioned 'NOT LEAKPROOF' in the SQL.
>>>> So, I am not sure, we should remove it or not.
>>>>
>>>
>>> Well we should be consistent - we either list the full set of all
>>> options, or just the non-default ones. The main thing is that we don't
>>> explicitly show options that are the default in some cases, but not in
>>> others.
>>>
>>>
>> Agreed. Fixed for LEAKPROOF and PARALLEL options.
>>
>
> This seems to work in edit mode, but not in create mode, where the
> PARALLEL option that's selected is simply ignored in the msql.
>
>
Fixed

> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>