Re: [pgAdmin 4][Patch]: RM 3559 - Far too many mouse clicks to drill down in Browser

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin 4][Patch]: RM 3559 - Far too many mouse clicks to drill down in Browser
Date: 2018-12-20 11:38:50
Message-ID: CAFOhELdPzwRRCLVkhWWiC5_rdYS94=7HHPi-tNetugRZEXbN8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Dec 20, 2018 at 4:01 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Tue, Dec 18, 2018 at 9:46 AM Khushboo Vashi
> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
> >
> > Hi,
> >
> > Please find the attached patch to fix the issue reported in RM #3559
> (Far too many mouse clicks to drill down in Browser) related to Tree Save
> State.
> > This RM was updated by the user with the issues in the browser tree
> state save functionality with the reproduction steps. These issues have
> been fixed in the attached patch.
>
> Thanks - whilst the patch seems to work (based on the description you
> sent me that I've pasted below for reference), I do see a problem.
> Basically, the first time I try to re-open a server that has a
> previously-saved state, the Databases node underneath it shows with an
> indefinite busy indicator. I can still use the tree under it - and if
> I then refresh the entire browser, the problem goes away and doesn't
> come back. Refreshing the node doesn't help though.
>
> I have slightly changed the data structure, may be it is causing the issue.
Please find the attached updated patch with the fix.

> > The fixed issues:
> >
> > 1. Expand any database > Close the database node > Refresh the Server.
> > Issue - The closed database opens up even if we have closed before
> Refreshing the server.
> > 2. Expand 3 to 4 databases till Table node with the same schema name
> (Ex; Public) > Refresh the browser
> > Issue - Not all the Table nodes will expand, it will expand till
> Schema only
> > 3. Expand any database till Table > Close the database node > Refresh
> the Browser
> > Issue - When I open the database node, it does not open the tree
> till Table node
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

Attachment Content-Type Size
RM_3559_v1.patch application/octet-stream 6.6 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2018-12-20 11:42:40 Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export
Previous Message Dave Page 2018-12-20 11:18:30 Re: [pgAdmin4][Patch] - RM 3780 pgAdmin4 lacks ability to specify NULL values in CSV export