Re: [pgAdmin4][Patch]: Feature #2506 - Allow the dashboard panel to be closed

Hi Dave,

On Tue, Jun 27, 2017 at 8:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> I've had to revert this. Whilst it seems to work, after showing/hiding the
> dashboard, I later find that when I completely reload the app, it fails,
> leaving just the object menu present. I haven't come up with a concrete
> case to reproduce it. In the console, I see:
>
>
> wcDocker.min.js:38 Uncaught TypeError: Cannot read property '__save' of
> null at e.save (wcDocker.min.js:38) at Object.save_current_layout (
> browser.js:340) at e.handleVisibility (panel.js:156) at e.__trigger (
> wcDocker.min.js:34) at e.trigger (wcDocker.min.js:38) at e.clear (
> wcDocker.min.js:38) at Object.init (browser.js:386) at (index):278 at
> Object.execCb (require.min.js:29) at Z.check (require.min.js:18)
>
> I couldn't reproduce this issue. I have tried many things to reproduce it
but not succeeded. I also switched server_mode but no luck.
I think there should be any specific condition that fails this but have no
clue.

I have rebased this patch and attached.

> On Tue, Jun 27, 2017 at 9:21 AM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>
>> Thanks, patch applied.
>>
>> On Tue, Jun 27, 2017 at 2:58 AM, Khushboo Vashi <
>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi,
>>>
>>> Please find the attached updated patch.
>>>
>>> Thanks,
>>> Khushboo
>>>
>>> On Mon, Jun 26, 2017 at 5:08 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>>> Hi
>>>>
>>>> Looks good, except that when I close the dashboard panel, it continues
>>>> to run the queries to update the graphs until I change the selected
>>>> treeview node. Can we stop it immediately?
>>>>
>>>> Fixed
>>>
>>>> On Mon, Jun 26, 2017 at 1:56 AM, Khushboo Vashi
>>>> <khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>> > Hi,
>>>> >
>>>> > Please find the attached patch for the feature #2506: Allow the
>>>> dashboard
>>>> > panel to be closed.
>>>> >
>>>> > Thanks,
>>>> > Khushboo
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>