Re: [gpAdmin4][patch] query history updates

Hi Wenlin & Violet,

On Tue, Aug 8, 2017 at 12:05 PM, Wenlin Zhang <wzhang(at)pivotal(dot)io> wrote:

> Hi Khushboo,
>
> Thanks for your review.
>
> About the copy/paste function bug, we just found that this is an
> existing bug in master. Except for the query History tab, this bug also
> exist in the query data output . If you copy the data row in "Data Output"
> tab, it works fine, but the copy/paste in query tool won't work either. We
> will create a Redmine bug later.
>
> And the feature test failure, we've already sent a new patch that
> fixed it. See this patch
> <https://www.postgresql.org/message-id/flat/CAEawo3JKQFuVeSK-xw9wU4fUSY57KXU5GeXKcdCusQeHkjTykA%40mail.gmail.com>
>
> I need to test this patch with the history tab update patch. Right now I
can not apply this patch on top of the history update patch.
Can you please re-base that patch?

> Thanks,
>
> Wenlin & Violet
>
>
> On Mon, Aug 7, 2017 at 1:45 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Sarah & Hao,
>>
>> The copy/paste functionality through the added copy button is working
>> fine, however once I copy the query text from the History tab through the
>> copy button, I can not perform copy/paste for some another text in the
>> Query tool.
>>
>> Also, the feature test (QueryToolJourneyTest) is failing, please refer
>> the attached screen-shot.
>>
>> Thanks,
>> Khushboo
>>
>> On Thu, Aug 3, 2017 at 9:03 AM, Hao Wang <haowang(at)pivotal(dot)io> wrote:
>>
>>> Hi Hackers,
>>>
>>> Here is a patch for query tools history UX improvements:
>>>
>>> - Add copy button for query text
>>> - Historical queries are binned by day
>>>
>>> Thanks,
>>> Sarah & Hao
>>>
>>
>>
>
Thanks,
Khushboo