Re: RM2233 - Scratch pad

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Subject: Re: RM2233 - Scratch pad
Date: 2019-02-15 11:53:35
Message-ID: CAFOhELdGemGkRYnsQj9fomiA+FqOZ_9fQs0oHKXk-4HP1AwKPQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,

On Thu, Feb 14, 2019 at 8:14 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Here's a draft patch for adding a scratch pad to the Query Tool,
> similar to what we had in pgAdmin 3.
>
> Aside from regular review, can one of our CSS gurus (I'm looking at
> you Aditya and Khushboo :-) ) help with the following questions:
>
> 1) I'm currently sizing the text area height using "height: calc(100%
> - 3px);" to avoid a vertical scrollbar in one of the parent divs
> created by wcDocker. I'm sure there's a more elegant way of doing that
> (and one that's not likely to be so fragile).
>
> Can't we just add height: 100% instead of calc?
One more way to avoid vertical scroll-bar is *overflow-y: hidden *

> 2) I've enabled the wcDocker context menu so users can show or hide
> the scratch pad. The sub-menu is expanding as shown in the attached
> screenshot though, however, it works fine on the main browser wcDocker
> instance.
>
> Please add 'jquery.ui', 'jqueryui.position' dependencies in sqleditor.js
.

Any ideas on those please?
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2019-02-15 13:04:48 Re: RM2233 - Scratch pad
Previous Message Dave Page 2019-02-14 14:44:45 RM2233 - Scratch pad