Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch] - RM 3853 - Incorrect SQL generated for create script of domain type interval with precision. ERROR: syntax error at or near "["
Date: 2019-01-22 11:58:16
Message-ID: CAFOhELd=tqo1sbZZ+CcdEDtiL7W4g8M-F0aRi7fXnmQ2siAvRA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi,

Please find the attached updated patch.

On Tue, Jan 22, 2019 at 4:17 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Khushboo
>
> On Tue, Jan 22, 2019 at 3:51 PM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi Akshay,
>>
>> Please find the attached updated patch.
>>
>> On Mon, Jan 21, 2019 at 2:57 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Khushboo
>>>
>>> Can you please fix the following and send the patch again
>>>
>>> - PEP8 issue
>>>
>>> Fixed
>>
>>>
>>> - Test cases is failing with Python 3.5.
>>>
>>> I have tested with Python 3.7 and it is working fine. Please give me the
>> log to reproduce the issue.
>>
>
> I have tested it with Python 3.5 with PG10 and 11. Attached is the
> screenshot.
>
>>
>>> Fixed.

> On Mon, Jan 21, 2019 at 2:06 PM Khushboo Vashi <
>>> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please find the attached patch to fix the RM #3853 - Incorrect SQL
>>>> generated for create script of domain type interval with precision. ERROR:
>>>> syntax error at or near "["
>>>>
>>>> The patch includes the fix as well as the API test case to verify the
>>>> reverse Engineered SQL.
>>>>
>>>> Thanks,
>>>> Khushboo
>>>>
>>>
>>>
>>> Thanks,
>> Khushboo
>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>

Attachment Content-Type Size
RM_3853_v2.patch application/octet-stream 9.2 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2019-01-22 12:01:32 Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working
Previous Message Dave Page 2019-01-22 11:57:18 Re: [pgAdmin4][RM3849] Ask to save unsaved query changes stopped working