Re: [pgAdmin4[RM#3948] Fix backform note control style

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Murtuza Zabuawala <murtuza(dot)zabuawala(at)enterprisedb(dot)com>, Chethana Kumar <chethana(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4[RM#3948] Fix backform note control style
Date: 2019-01-30 11:09:45
Message-ID: CAFOhELcqqKvPGYk=NSV0hpN+iBut_g1B_Azk2c_Hoe-fRerLtg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Murtuza,

I have reviewed your patch and I feel we need Chethana's suggestion on this.

@ Chethana,

Please have a look the attached screen-shots (Existing_design and
Proposed_design). With this patch the *Note* section design has been
changed.
We need your suggestion on this to improve it as I feel it needs
improvement.

Thanks,
Khushboo

On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <
murtuza(dot)zabuawala(at)enterprisedb(dot)com> wrote:

> Hi,
>
> PFA minor patch to fix the style, changed the background colour and text
> colour so that it can be readable.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>

Attachment Content-Type Size
Existing_design.png image/png 630.2 KB
Proposed_design.png image/png 633.1 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2019-01-30 11:09:47 pgAdmin 4 commit: Handle backend errors properly and display them corre
Previous Message Murtuza Zabuawala 2019-01-30 10:22:00 [pgAdmin4[RM#3948] Fix backform note control style