| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Shubham Agarwal <shubham(dot)agarwal(at)enterprisedb(dot)com> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgadmin_page functions updated |
| Date: | 2018-06-15 05:32:58 |
| Message-ID: | CAFOhELcp=g9qyFwOc_4vejbu3TRCC3a0bTYyajifNc5Z8oj7TQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Shubham,
On Thu, Jun 14, 2018 at 3:25 PM, Shubham Agarwal <
shubham(dot)agarwal(at)enterprisedb(dot)com> wrote:
> Hi Team,
>
> I have modified following two functions in pgadmin_page.py :-
>
> 1. click_tab() -> Added wait till element is clickable, test cases are
> failing since the function attempts to click the tab which is not yet in
> the state to be clicked.
>
> 2. add_server() -> Replaced the sleep statement with wait till element to
> be clickable.
>
> Please find the attached patch.
>
> We should start using CSS selectors instead of xpath, otherwise the patch
works fine and also changes look good to me.
> --
> Thanks & Regards,
> Shubham Agarwal
> EnterpriseDB Corporation
>
> The Postgres Database Company
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shubham Agarwal | 2018-06-15 06:03:32 | Re: pgadmin_page functions updated |
| Previous Message | Khushboo Vashi | 2018-06-15 05:16:16 | Re: RM#3294 - User need to reset the layout to see the changed preferences parameters |