| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Dave Page <dpage(at)pgadmin(dot)org> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Patch to remove Python 2.7 support in the macOS Appbundle |
| Date: | 2020-04-27 14:27:55 |
| Message-ID: | CAFOhELcg2mvFVs_tfv_xtiLmceR41EUjFZmNzWj37CFNCgsCNw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi,
The code looks good to me. The package building was tested by Neel and we
found that the venv was built with Python 3+ but the runtime was built
against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is
working fine on Dav'e system. So, we can commit the patch.
Thanks,
Khushboo
On Mon, Apr 27, 2020 at 3:16 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:
> The attached patch removes support for Python 2.7 in general from the
> macOS appbundle build, thus also removing special handling for use of the
> system Python installation.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2020-04-27 14:30:57 | Re: Patch to remove Python 2.7 support in the macOS Appbundle |
| Previous Message | Aditya Toshniwal | 2020-04-27 14:00:51 | [pgAdmin][RM5441] Not able to find path toast tables under pg_toast schema |