Re: [pgAdmin4][Patch]: Backgrid StringDepsCell

From: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
To: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: Backgrid StringDepsCell
Date: 2016-04-01 10:26:57
Message-ID: CAFOhELcZpPHsuV9KgCmwSypp=Q9Qr0kXb=cs4=8eU=h20YGVZg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Ashesh,

Yes, agreed. This implementation limits us to use only String Cell.
So, I have modified the patch as you suggested.

Please find the attachment for the same.

Thanks,
Khushboo

On Fri, Apr 1, 2016 at 2:59 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
wrote:

> Hi Khushboo,
>
> I am reluctant to use this code as it is.
> I would prefer you create just helper functions (i.e. initialize, remove)
> for the dependents in Backgrid.Cell, and then use them directly from the
> different cell itself.
> Because - this functionality limits us to us only with the string type.
>
> Anyway - we will be using the dependent functionality for very attributes.
>
>
> You can extend them directly in the Node's model (schema).
>
> --
>
> Thanks & Regards,
>
> Ashesh Vashi
> EnterpriseDB INDIA: Enterprise PostgreSQL Company
> <http://www.enterprisedb.com>
>
>
> *http://www.linkedin.com/in/asheshvashi*
> <http://www.linkedin.com/in/asheshvashi>
>
> On Wed, Mar 30, 2016 at 6:39 PM, Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch for the Backgrid *StringDepsCell.*
>>
>> The *StringDepsCell* displays HTML escaped strings and accepts anything typed in.
>> Also, Listen to the dependent fields.
>>
>>
>> Usage of the Backgrid Cell:
>>
>> If the Precision cell is dependent on the Datatype then:
>>
>> {
>> id: 'precision', label:'{{ _('Precision') }}', type: 'test'
>> cell: *Backgrid.Extension.StringDepsCell*, deps: ['datatype']
>>
>> }
>>
>>
>> Thanks,
>> Khushboo
>>
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>

Attachment Content-Type Size
pgAdmin4_Backgrid_Depscell.patch text/x-patch 1.8 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2016-04-01 11:47:49 Re: [pgAdmin4][Patch] Add formatted error message support in psycopg2
Previous Message Ashesh Vashi 2016-04-01 10:23:33 Re: [pgAdmin4][Patch] Add formatted error message support in psycopg2