| From: | Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com> |
|---|---|
| To: | Joao De Almeida Pereira <jdealmeidapereira(at)pivotal(dot)io> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: [pgAdmin4][Patch]: RM 3284 - F5 key not working consistently |
| Date: | 2018-04-30 06:48:44 |
| Message-ID: | CAFOhELcTkgW36DVx0cd8So40Ku4SbKDjukoz17ck8gEZnQiVjA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Joao,
The patches look good however I have noticed that you
deleted attachShortcut and attachDialogTabNavigatorShortcut functions from
keyboard.js, any specific reason for that?
Thanks,
Khushboo
On Fri, Apr 27, 2018 at 3:11 AM, Joao De Almeida Pereira <
jdealmeidapereira(at)pivotal(dot)io> wrote:
> Hi Khushboo,
>
> I did some changes on your patch:
> 0001 - Your original patch
> 0002 - Convert keyboard.js to ES6
> 0003 - Refactoring of the keyboard.js file(some one letter variables and
> other code)
>
>
>
> Thanks
> Joao
>
> On Thu, Apr 26, 2018 at 5:34 AM Khushboo Vashi <
> khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the attached patch to fix the RM #3284 : F5 key not working
>> consistently.
>>
>> - Added the configurable keyboard shortcut (default F5) to refresh the
>> browser tree nodes.
>>
>>
>> Thanks,
>> Khushboo
>>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anthony Emengo | 2018-04-30 10:21:08 | Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree |
| Previous Message | Ashesh Vashi | 2018-04-30 06:16:47 | Re: [pgadmin4][patch] Initial patch to decouple from ACI Tree |